Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tail: allow -n1 and -n 1 #399

Merged
merged 1 commit into from
Jan 3, 2024
Merged

tail: allow -n1 and -n 1 #399

merged 1 commit into from
Jan 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2024

  • I habitually type "tail -n5"; this is supported by GNU tail and OpenBSD tail
  • Enabling bundling option in Getopt::Long makes it work in this version
  • Style: avoid capture variable when the entire argument string "+590" is passed to check_number()
  • test1: "perl tail -5 tail" -- historical option format, last 5 lines
  • test2: "perl tail +590 tail" -- historical option format, line 590 to end
  • test3: "perl tail -n5 tail" -- last 5 lines
  • test4: "perl tail -n-5 tail" -- last 5 lines
  • test5: "perl tail -n+590 tail" -- line 590 to end

@mknos
tail: allow -n1 and -n 1
742ff51 
* I habitually type "tail -n5"; this is supported by GNU tail and OpenBSD tail
* Enabling bundling option in Getopt::Long makes it work in this version
* Style: avoid capture variable when the entire argument string "+590" is passed to check_number()
* test1: "perl tail -5 tail" -- historical option format, last 5 lines
* test2: "perl tail +590 tail" -- historical option format, line 590 to end
* test3: "perl tail -n5 tail" -- last 5 lines
* test4: "perl tail -n-5 tail" -- last 5 lines
* test5: "perl tail -n+590 tail" -- line 590 to end
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Jan 3, 2024
@briandfoy briandfoy self-assigned this Jan 3, 2024
@briandfoy
Copy link
Owner

Does this change need to happen in head too?

@briandfoy briandfoy merged commit 37478ea into briandfoy:master Jan 3, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 3, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy