A couple of small fixes for VDUStreamProcessor #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesims
commented
Sep 25, 2023
| @@ -174,11 +174,10 @@ void VDUStreamProcessor::setOutputStream(uint16_t bufferId) { | |||
| } | |||
| } | |||
|
|
|||
| uint16_t VDUStreamProcessor::getBufferByte(uint16_t bufferId, uint32_t offset) { | |||
| int16_t VDUStreamProcessor::getBufferByte(uint16_t bufferId, uint32_t offset) { | |||
There was a problem hiding this comment.
this function can return -1, so it needs to be a signed int
| if (buffers.find(bufferId) != buffers.end()) { | ||
| // buffer ID exists | ||
| // loop thru buffers stored against this ID to find data at offset | ||
| uint32_t value = 0; |
There was a problem hiding this comment.
compiler warnings show up this unused variable 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor fixes to typing (catching potential logic flaws) and compiler warnings that I'd made in the Console8 codebase had slipped past when raising PRs. Soz!