Same batch Create + Update records should resolve to Create #97

ayumi · 2017-06-07T21:21:58Z

Also:

Fix bug where recordUtil.resolveRecords() would mutate in-place.
Improve human level of "Ignoring [record action] of object [1,2,3]" so it says the action string instead of number.

Bonus test plan:

yarn dist into browser-laptop
run browser-laptop and sync to the sync profile of Renamed folder never fetches #91:

squalider piccalilli mutate decomposability
waterily nonaligned watershed homeward
aidman tat nobleman filling
chromaticism copolymerizing prythee gonococci

confirm the bookmark folder "123456"

cc @SergeyZhukovsky

@diracdeltas

Also fixes bug where recordUtil.resolveRecords() would mutate in-place. Fix #91 Auditors: @diracdeltas

diracdeltas

test plan worked. lgtm assuming travis is stoked

Same batch Create + Update records should resolve to Create

865c2e5

Also fixes bug where recordUtil.resolveRecords() would mutate in-place. Fix #91 Auditors: @diracdeltas

ayumi requested a review from diracdeltas June 7, 2017 21:21

diracdeltas approved these changes Jun 7, 2017

View reviewed changes

ayumi merged commit 9325e6d into staging Jun 8, 2017

ayumi deleted the fix/merge-batched-record-actions branch June 8, 2017 00:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Same batch Create + Update records should resolve to Create #97

Same batch Create + Update records should resolve to Create #97

ayumi commented Jun 7, 2017 •

edited

Loading

diracdeltas left a comment

Same batch Create + Update records should resolve to Create #97

Same batch Create + Update records should resolve to Create #97

Conversation

ayumi commented Jun 7, 2017 • edited Loading

diracdeltas left a comment

Choose a reason for hiding this comment

ayumi commented Jun 7, 2017 •

edited

Loading