Skip to content
This repository was archived by the owner on Jul 31, 2020. It is now read-only.

change limitResponse to a maxRecords number #88

Merged
merged 1 commit into from
May 12, 2017
Merged

change limitResponse to a maxRecords number #88

merged 1 commit into from
May 12, 2017

Conversation

diracdeltas
Copy link
Member

fix #87

@diracdeltas diracdeltas requested a review from ayumi May 11, 2017 23:02
ayumi
ayumi approved these changes May 11, 2017
View reviewed changes
Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, what happens when you limit to something big like 9001?

@diracdeltas
Copy link
Member Author

@ayumi i think AWS gives you an error https://forums.aws.amazon.com/thread.jspa?threadID=14527

@ayumi
Copy link
Contributor

ayumi commented May 12, 2017

sweet

@diracdeltas diracdeltas merged commit 66b5b22 into staging May 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ayumi ayumi ayumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configurable record limit number on fetch
2 participants
@diracdeltas @ayumi