Collapse code into a single main package. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2023 08:23
We have been maintaining a main package, a nitriding package, and a
randseed package. All these packages are a relic of the past. This
commit moves all code to the root directory, so we only have to maintain
a single main package.
This has the added benefit of no longer needing the "cmd" suffix when
installing nitriding, i.e., users can now run:
go install github.com/brave/nitriding-daemon@latest
This PR fixes #12.
This target results in an HTML file that nicely illustrates what lines of code are covered by our tests.
This is unrelated to the rest of this PR but it makes the code more consistent.
rillian
previously approved these changes
May 29, 2023
Comment on lines
+16
to
+18
| .PHONY: coverage | ||
| coverage: $(cover_html) | ||
| ${BROWSER} $(cover_html) |
There was a problem hiding this comment.
Is it possible to add this to the ci feedback? I find "coverage went up/down" messages are usually too noisy, but it can be nice to have the report available through the github interface.
There was a problem hiding this comment.
That sounds useful but I have no cycles to work on this, so I suggest working on this in a separate issue.
rillian
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the respective commit messages for what this PR does.