This repository was archived by the owner on Jan 4, 2019. It is now read-only.
Enable importing passwords from Firefox #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
reviewed
Jun 13, 2017
| importer_->Emit("add-password-form", imported_form); | ||
| } | ||
| PasswordStoreFactory::GetForProfile( | ||
| ProfileManager::GetActiveUserProfile(), ServiceAccessType::EXPLICIT_ACCESS)->AddLogin(form); |
There was a problem hiding this comment.
I think we should do null check of Profile*
evq
force-pushed
the
feature/password-import
branch
from
c54c4d2 to
f2aa48a
Compare
darkdh
reviewed
Jun 14, 2017
| while (s.Step() && !cancelled()) { | ||
| autofill::PasswordForm form; | ||
| base::string16 origin = s.ColumnString16(0); | ||
| form.origin = GURL(base::StringPiece16(origin)); |
There was a problem hiding this comment.
you can directly use GURL(s.ColumnString16(0)); here
darkdh
suggested changes
Jun 14, 2017
| autofill::PasswordForm form; | ||
| base::string16 origin = s.ColumnString16(0); | ||
| form.origin = GURL(base::StringPiece16(origin)); | ||
| form.signon_realm = base::UTF16ToUTF8(origin) + '/'; |
There was a problem hiding this comment.
use form.origin.GetOrigin().spec() would be better
8 tasks
evq
force-pushed
the
feature/password-import
branch
from
f2aa48a to
9481c08
Compare
darkdh
approved these changes
Jun 14, 2017
bridiver
reviewed
Jun 17, 2017
| if ((items & importer::PASSWORDS) && !cancelled()) { | ||
| bridge_->NotifyItemStarted(importer::PASSWORDS); | ||
| ImportPasswords(); | ||
| - bridge_->NotifyItemEnded(importer::PASSWORDS); |
There was a problem hiding this comment.
why are we leaving out the notification for passwords?
There was a problem hiding this comment.
I see now, we also do part of the import in brave/utility/importer/firefox_importer.cc
Is this something we can upstream so we don't have to patch in the future?
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @darkdh
required by brave/browser-laptop#9433