This repository was archived by the owner on Jan 4, 2019. It is now read-only.
Add chrome.cookies.{getAll, set, get} for Pinterest Save Button extension, brave/browser-laptop#6366 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlawler
force-pushed
the
pinterest-save
branch
from
072e365 to
2c4c390
Compare
kevinlawler
changed the title
kevinlawler
force-pushed
the
pinterest-save
branch
3 times, most recently
from
fdbb851 to
b34d1c3
Compare
bridiver
reviewed
Jun 6, 2017
| @@ -18,7 +18,7 @@ | |||
| #include "base/strings/utf_string_conversions.h" | |||
| #include "base/threading/thread_task_runner_handle.h" | |||
| #include "brave/browser/brave_content_browser_client.h" | |||
| #include "chrome/browser/importer/external_process_importer_host.h" | |||
| #include "brave/browser/importer/brave_external_process_importer_host.h" | |||
There was a problem hiding this comment.
I think these changes are unintentional? If you can clean them up I'll get it merged
kevinlawler
force-pushed
the
pinterest-save
branch
from
b34d1c3 to
eec9cc5
Compare
|
@bridiver rebased against master. lmk if you need any other changes |
bridiver
reviewed
Jun 8, 2017
| @@ -142,6 +142,9 @@ void ComponentUpdater::RegisterComponent(const std::string& component_id) { | |||
| } else if (component_id == kHoneyId) { | |||
| RegisterComponentForUpdate( | |||
| kHoneyPublicKeyStr, registered_callback, ready_callback); | |||
| } else if (component_id == kPinterestId) { | |||
There was a problem hiding this comment.
@bbondy do we still need these? Can't we just register them in browser-laptop using the component api?
…sion (commit split from Pinterest key) brave/browser-laptop#6366 brave/browser-laptop#6262 brave/browser-laptop#8389
kevinlawler
force-pushed
the
pinterest-save
branch
from
eec9cc5 to
710685d
Compare
|
split cookies fixes into separate branch/pr from pinterest key |
kevinlawler
added a commit
that referenced
this pull request
Jun 8, 2017
kevinlawler
added a commit
that referenced
this pull request
Jun 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See brave/vault-updater#42