Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

Add testing #24

Closed
wants to merge 6 commits into from
Closed

Add testing #24

wants to merge 6 commits into from

Conversation

RyanJarv
Copy link

@RyanJarv RyanJarv commented Nov 7, 2017

Work in progress for #11, figured I'd open a PR so people know it's here for now. Let me know if anyone has any suggestions or comments on it.

@RyanJarv RyanJarv changed the title [WIP] Add testing Add testing Nov 14, 2017
@RyanJarv
Copy link
Author

Believe I got most of the currently used functions here. May come have to come back to the rest later.

@NejcZdovc
Copy link
Contributor

cc @mrose17 @diracdeltas @evq

@evq
Copy link
Member

evq commented Nov 16, 2017

OMG tests 😍

Hey @RyanJarv, thank you so much for taking the time to put together these tests for our ledger client!

I'm really sorry, but unfortunately we won't be merging this pull request. We've actually moved core development of our ledger client to https://github.com/brave-intl/bat-client to coincide with our migration from the BTC payments system to our new BAT based system. I haven't looked closely yet, but we may be able to re-use these tests there with some slight adjustments. We are also looking at re-writing the ledger client to be more easily usable across various platforms so it may be we just take inspiration from these tests as that work proceeds.

Thanks again for contributing!

P.S. I'll be pushing some updates that point at our new repos to make it more clear what is actively being developed. Sorry we haven't already done that!

@evq evq closed this Nov 16, 2017
@RyanJarv
Copy link
Author

Ah ok, I suppose that makes now that I think about it.. Well hopefully those will be useful for reference at least.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants