Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Fix autoplay test #9739

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Fix autoplay test #9739

merged 1 commit into from
Jun 27, 2017

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jun 27, 2017

activate URL mode before click reload button

Auditors: @NejcZdovc, @bsclifton

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

# **window 1**
npm run watch-all

# **window 2**
npm run test -- --grep="Autoplay test"

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

activate URL mode before click reload button

Auditors: @NejcZdovc, @bsclifton
@darkdh darkdh self-assigned this Jun 27, 2017
@darkdh darkdh requested review from bsclifton and NejcZdovc June 27, 2017 15:32
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great 😄

@bsclifton bsclifton merged commit b364c56 into master Jun 27, 2017
@bsclifton bsclifton deleted the autoplay-test-fix branch June 27, 2017 18:53
bsclifton added a commit that referenced this pull request Jun 27, 2017
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants