test and split TabsTab component #9694

cezaraugusto · 2017-06-24T00:48:31Z

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.

Test Plan:

npm run test -- --grep="TabsTab component"

Auditors @bsclifton
Close #7398
Address #9558

Reviewer Checklist:

Tests

Adequate test coverage exists to prevent regressions
Tests should be independent and work correctly when run individually or as a suite ref
New files have MPL2 license header

@bsclifton

Auditors: @bsclifton Close #7398 Test Plan: covered by automated tests

bsclifton

One step closer! Thanks for breaking this out of the massive preferences file 😄

cezaraugusto added 2 commits June 23, 2017 21:44

Split TabsTab to its own file

24bf5fe

Auditors: @bsclifton Close #7398 Test Plan: covered by automated tests

Add tests for TabsTab component

d31b378

cezaraugusto added the settings label Jun 24, 2017

cezaraugusto added this to the 0.19.x (Nightly Channel) milestone Jun 24, 2017

cezaraugusto self-assigned this Jun 24, 2017

cezaraugusto requested review from luixxiul and bsclifton June 24, 2017 00:48

bsclifton approved these changes Jun 25, 2017

View reviewed changes

bsclifton merged commit 9c10fa7 into brave:master Jun 25, 2017

bsclifton added automated-tests QA/no-qa-needed release-notes/exclude labels Jun 25, 2017

cezaraugusto deleted the pref/7398 branch July 25, 2017 07:23

Provide feedback