Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Fixes unit tests, broken with #9650 #9675

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Fixes unit tests, broken with #9650 #9675

merged 1 commit into from
Jun 23, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 23, 2017 •
edited by bsclifton
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Auditors: @bsclifton

Test Plan:

  • unit test should pass

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc
Fixes unit tests, broken with brave#9650
7df8ce5 
Auditors: @bsclifton

Test Plan:
- unit test should pass
@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 23, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 23, 2017
@NejcZdovc NejcZdovc requested a review from bsclifton June 23, 2017 06:14
bsclifton
bsclifton approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes- good catch! 😄 (definitely a miss on my part)

@bsclifton bsclifton merged commit 058eec2 into brave:master Jun 23, 2017
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9675 from NejcZdovc/hotfix/unittest-advancedTabTest
01ce539 
Fixes unit tests, broken with #9650
bsclifton added a commit that referenced this pull request Jun 23, 2017
@bsclifton
Merge pull request #9675 from NejcZdovc/hotfix/unittest-advancedTabTest
79f7014 
Fixes unit tests, broken with #9650
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests QA/no-qa-needed
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @bsclifton