This repository was archived by the owner on Dec 11, 2019. It is now read-only.
add metamask to available extensions #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#8671 already added to vault manifest & live on server brave/vault-updater#43 Auditors: @bridriver @bsclifton @jonathansampson
kevinlawler
requested review from
bridiver,
diracdeltas,
jonathansampson and
bsclifton
bridiver
approved these changes
Jun 29, 2017
bsclifton
approved these changes
Jun 30, 2017
There was a problem hiding this comment.
Seems to work great 😄
When the extension pops up, it's a little janky- not sure what's up with that. Doesn't affect the usability though (here's a screenshot). Hard to see, but it shows offscreen, then slides in? maybe it's intended. Sometimes, I see the window down below too (before the final one is shown)
|
the resizing is normal, but we could probably eliminate it by debouncing |
|
@bridiver I wonder if that same logic is affecting LastPass (the popup is sized incorrectly when DPI is increased). Can you share a link? |
bsclifton
modified the milestones:
0.19.x (Nightly Channel),
0.18.x (Developer Channel)
|
Moving to 0.19.x because there is code this depends on (see #9585) |
|
Does this close #8671? |
luixxiul
added
the
needs-info
|
@luixxiul I don't think so- cc: @jonathansampson |
This was referenced Dec 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8671
already added to vault manifest & live on server
brave/vault-updater#43
Auditors:
@bridiver @bsclifton @jonathansampson