Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Fixes some failing tests #9639

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 21, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9638

Auditors: @bsclifton

Test Plan:

  • tests should be green

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 21, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 21, 2017
@NejcZdovc NejcZdovc force-pushed the hotfix/#9638-tests branch from d710f44 to f3832f9 Compare June 21, 2017 12:15
Resolves brave#9638

Auditors: @bsclifton

Test Plan:
- tests should be green
@NejcZdovc NejcZdovc force-pushed the hotfix/#9638-tests branch from f3832f9 to 838b44e Compare June 23, 2017 10:50
@NejcZdovc NejcZdovc mentioned this pull request Jun 23, 2017
@NejcZdovc NejcZdovc merged commit 1102e38 into brave:master Jun 23, 2017
@luixxiul luixxiul requested a review from bsclifton June 23, 2017 14:09
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants