Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Unpinning tab intermittently does not display the title on tabs #9625

Merged
merged 2 commits into from
Jun 21, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 21, 2017

Fix #9608

Auditors: @cezaraugusto

Note that since it's intermittent I think the test would also pass before, but I can't find a way to get a unique test to always fail. Same as if I test manually

The test will at least ensure that unpinning gives a title always
though.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.17.x (Beta Channel) milestone Jun 21, 2017
@bbondy bbondy self-assigned this Jun 21, 2017
@bbondy bbondy requested a review from cezaraugusto June 21, 2017 03:45
Fix #9608

Auditors: @cezaraugusto

Note that since it's intermittent I think the test would also pass before, but I can't find a way to get a unique test to always fail.  Same as if I test manually

The test will at least ensure that unpinning gives a title always
though.
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy
Copy link
Member Author

bbondy commented Jun 21, 2017

A+++++++ on the test! Would review again!!!

@cezaraugusto cezaraugusto merged commit f602c3d into master Jun 21, 2017
@cezaraugusto cezaraugusto deleted the 9608 branch June 21, 2017 05:23
cezaraugusto added a commit that referenced this pull request Jun 21, 2017
Unpinning tab intermittently does not display the title on tabs
cezaraugusto added a commit that referenced this pull request Jun 21, 2017
Unpinning tab intermittently does not display the title on tabs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants