Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Show right number of tabs when closing with mouse on first tab in new… #9618

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 21, 2017

… tab page

Fix #9561

Auditors: @bsclifton

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Automated test plan

npm run test -- --grep="shows the right number of tabs after closing with mouse"

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bbondy bbondy added this to the 0.17.x (Beta Channel) milestone Jun 21, 2017
@bbondy bbondy self-assigned this Jun 21, 2017
@bbondy bbondy requested a review from bsclifton June 21, 2017 01:14
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; test works perfectly as described. Since the test matches the steps specified so closely, I marked this as no-qa-needed. Great job 😄

@bsclifton bsclifton merged commit dda13f7 into master Jun 21, 2017
@bsclifton bsclifton deleted the 9561 branch June 21, 2017 04:44
bsclifton added a commit that referenced this pull request Jun 21, 2017
Show right number of tabs when closing with mouse on first tab in new…
bsclifton added a commit that referenced this pull request Jun 21, 2017
Show right number of tabs when closing with mouse on first tab in new…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants