This repository was archived by the owner on Dec 11, 2019. It is now read-only.
fix noscript allow-once for selective scripts #9595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9150
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
1. block scripts globally
2. go to twitter.com
3. click the noscript icon, make sure only 'twitter.com' is checked, click 'allow once'
4. close the tab
5. open twitter.com in a new tab
3. click the noscript icon. 'twitter.com' should appear in the list.
Reviewer Checklist:
Tests