Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

fix noscript allow-once for selective scripts #9595

Merged
merged 1 commit into from
Jun 22, 2017
Merged

fix noscript allow-once for selective scripts #9595

merged 1 commit into from
Jun 22, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 20, 2017

fix #9150

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:
1. block scripts globally
2. go to twitter.com
3. click the noscript icon, make sure only 'twitter.com' is checked, click 'allow once'
4. close the tab
5. open twitter.com in a new tab
3. click the noscript icon. 'twitter.com' should appear in the list.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas diracdeltas added this to the 0.18.x (Developer Channel) milestone Jun 20, 2017
@diracdeltas diracdeltas self-assigned this Jun 20, 2017
fix #9150

test plan:
1. block scripts globally
2. go to twitter.com
3. click the noscript icon, make sure only 'twitter.com' is checked, click 'allow once'
4. close the tab
5. open twitter.com in a new tab
3. click the noscript icon. 'twitter.com' should appear in the list.
@luixxiul
Copy link
Contributor

If you set twitter.com as a new tab, the setting does not seem to be cleared by opening a new tab.

STR:

  1. Set https://www.twitter.com to your home page
  2. Open a new tab
  3. Click the noscript icon
  4. Click "allow this time"
  5. Open a new tab

Actual result: there does not appear the noscript icon. If you close the tab and open a new tab, then the icon appears again.

Expected result: the icon should appear on each new tab

noscript

Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback left.

@diracdeltas
Copy link
Member Author

@luixxiul the setting is expired when the tab closes, so it is expected that the noscript icon only appears again after a twitter tab has been closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Allow this time" on NoScript dialog keeps allowing scripts even after reopening the tab
3 participants