This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Take no action for middle click over pinned tabs #9528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Description
Submitter Checklist:
git rebase -i
to squash commits (if needed).Auditors: @bsclifton
Fix #9492
repeating comments left in #9492 (comment):
Middle click over pinnedTabs shouldn't be allowed until #4063 is solved. Doing it was leading to a weird update over tabs, setting unpinned tabs to the smallest breakpoint, which is visually similar to pinned tabs but with close button replacing icon while active.
for clarification, this pull-request copy the same behavior as Opera, which may not be our intention given FF, Chrome and Safari all close the tab. However, leave the discussion open until #4063.
/cc @srirambv
Reviewer Checklist:
Tests