Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Moves NotificationItem in a separate file #9520

Merged
merged 1 commit into from
Jun 16, 2017

Conversation

NejcZdovc
Copy link
Contributor

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Auditors: @bsclifton

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 16, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 16, 2017
@NejcZdovc NejcZdovc merged commit 1598fb2 into brave:master Jun 16, 2017
@bsclifton
Copy link
Member

@NejcZdovc was this intended to be merged already?

@bsclifton
Copy link
Member

Changes look good 😄 ++

@NejcZdovc
Copy link
Contributor Author

Yes, this PR only splited two files, that's why I merged it without reviews. You can see changes in #9518.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants