This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Cleanup of LoginRequired #9493
Merged
Cleanup of LoginRequired #9493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
redux/loginRequired
branch
from
01c2bf5 to
b57a646
Compare
Resolves brave#9446 Auditors: @bsclifton Test Plan:
NejcZdovc
force-pushed
the
redux/loginRequired
branch
from
b57a646 to
7cf3505
Compare
bbondy
reviewed
Jun 23, 2017
| </CommonFormButtonWrapper> | ||
| </CommonForm> | ||
| </Dialog> | ||
| } | ||
| } | ||
|
|
||
| LoginRequired.propTypes = { frameProps: PropTypes.object } | ||
| module.exports = LoginRequired |
There was a problem hiding this comment.
nit: I prefer this at the end of a file
There was a problem hiding this comment.
In all components we have this like that, so I would leave it for now and we can move it in all components to the bottom in a different PR
There was a problem hiding this comment.
ok I'm not concerned either way, was just noting.
There was a problem hiding this comment.
I noticed it as well and was trying to re-move the change.
There was a problem hiding this comment.
@NejcZdovc please document the rule on the wiki page for refactoring work, thanks. CC @cezaraugusto
bbondy
approved these changes
Jun 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #9446
Auditors: @bsclifton
Test Plan:
Reviewer Checklist:
Tests