don’t use sync ipc for publisher info

[bridiver]

Submitter Checklist:

the diff is mostly an indenting change from wrapping in ipcRenderer.once

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Test Plan:

1. Enable ledger
2. Visit some pubs long enough to add them
3. Pubs should show in ledger prefs

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[bsclifton]

@NejcZdovc would you be able to check this one out? 😄

[diracdeltas]

i think you can remove this message and its handler in app/ledger.js

[diracdeltas]

seems like a bunch of payments tests are failing: https://travis-ci.org/brave/browser-laptop/jobs/243018061

i'm not really familiar with how this code works, so defer to @NejcZdovc

[bsclifton]

I just rebased- will watch tests and check out soon 😄

[bridiver]

@diracdeltas @bsclifton ledger appears to be broken in master. With a fresh profile I can't initialize ledger, but the content script appears to be functioning correctly in this PR and master

[bridiver]

actually it works now, I think my node modules were out-of-date

[bridiver]

there was a variable name capitalization mismatch. Ledger tests are working now

[bsclifton]

@bridiver if we want to manually test, can you create an issue for this (and then edit commit to reference it?). If we don't need manual testing, let's add an automated test 😄

[bridiver]

there are automated tests. This doesn't add any new functionality

[bsclifton]

Manually tested, works great 😄 The advanced payment tests are failing, but that isn't related. The regular payment tests all pass 😄 👍 ++