Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

set webrtc handling policy in the browser process #9469

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 14, 2017

Submitter Checklist:

@diracdeltas what is a good way to test this?

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added the perf label Jun 14, 2017
@bridiver bridiver added this to the 0.17.x (Beta Channel) milestone Jun 14, 2017
@bridiver bridiver self-assigned this Jun 14, 2017
@diracdeltas
Copy link
Member

@bridiver i tested this originally by navigating between https://diafygi.github.io/webrtc-ips/ and https://browserleaks.com/webrtc (having shields down for one of them). it's also covered in the fingerprinting tests.

@NejcZdovc
Copy link
Contributor

@bridiver what is the status of this PR? is it ready for a review?

@bridiver
Copy link
Collaborator Author

yea, just need to verify tests

@bsclifton
Copy link
Member

bsclifton commented Jun 20, 2017

@bridiver if we'd like manual QA testing for this, can you create an issue?

It sounds like the steps @diracdeltas mentioned can be used in the test plan

navigating between https://diafygi.github.io/webrtc-ips/ and https://browserleaks.com/webrtc (having shields down for one of them)

@bsclifton bsclifton merged commit 22d2451 into master Jun 20, 2017
@bsclifton bsclifton deleted the webrt-browser branch June 20, 2017 05:26
bsclifton added a commit that referenced this pull request Jun 20, 2017
set webrtc handling policy in the browser process
@bsclifton
Copy link
Member

Because it relies on previous commits (specifically, #9154), this can't go into 0.17.x. Updating milestone to be 0.18.x

@bsclifton bsclifton modified the milestones: 0.18.x (Developer Channel), 0.17.x (Beta Channel) Jun 20, 2017
@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-info Another team member needs information from the PR/issue opener. perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants