Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

check for destroyed before sending to webContents #9462

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Jun 14, 2017

Submitter Checklist:

This is hard to reliably replicate, but sometimes on shutdown or window close it will try to send an update to a destroyed webContents

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bridiver bridiver added this to the 0.17.x (Beta Channel) milestone Jun 14, 2017
@bridiver bridiver self-assigned this Jun 14, 2017
@bridiver bridiver requested a review from bbondy June 14, 2017 18:42
@bbondy bbondy merged commit e8f4f25 into master Jun 15, 2017
bbondy added a commit that referenced this pull request Jun 15, 2017
check for destroyed before sending to webContents
bbondy added a commit that referenced this pull request Jun 15, 2017
check for destroyed before sending to webContents
@bsclifton bsclifton deleted the web-contents-send branch June 15, 2017 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants