Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Fix 'blocks fingerprinting' test #8746

Merged
merged 1 commit into from
May 11, 2017
Merged

Fix 'blocks fingerprinting' test #8746

merged 1 commit into from
May 11, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 7, 2017

Auditors:

Test Plan: npm run test -- --grep='blocks fingerprinting'

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

related: #8760

Auditors:

Test Plan: npm run test -- --grep='Bravery Panel'
@luixxiul
Copy link
Contributor Author

luixxiul commented May 9, 2017

note: as this test has been usually skipped on Travis due to iframe test errors reported on #8760, in this case please avoid relying on travis results and run the test (npm run test -- --grep='blocks fingerprinting') locally. thanks.

@luixxiul luixxiul modified the milestones: 0.15.3, 0.15.4 May 9, 2017
@NejcZdovc NejcZdovc merged commit d5848c7 into brave:master May 11, 2017
@luixxiul luixxiul deleted the fix-blocks-fingerprinting-test branch May 11, 2017 14:12
@luixxiul luixxiul requested a review from srirambv May 11, 2017 14:12
@luixxiul
Copy link
Contributor Author

CC @srirambv for double check.

@luixxiul luixxiul removed the request for review from srirambv June 2, 2017 04:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants