-
Notifications
You must be signed in to change notification settings - Fork 970
Conversation
d1f98da
to
93ee067
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. We should monitor feedback on legibility of the minimized numbers but I think the tradeoff is worth it considering the alternative used by other browsers where the icon is mostly blocked by the badge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsclifton @bradleyrichter The font-game on Linux is weak. I spent some last last week looking at our options, and we have very few. We may need to package a font to use in that case. System-supported defaults were not very promising. |
let’s just go bigger if needed. 1pt should help.
… On Apr 10, 2017, at 3:11 PM, Jonathan Sampson ***@***.***> wrote:
@bsclifton <https://github.com/bsclifton> @bradleyrichter <https://github.com/bradleyrichter> The font-game on Linux is weak. I spent some last last week looking at our options, and we have very few. We may need to package a font to use in that case. System-supported defaults were not very promising.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#8191 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AM4jqjP9PMo1_9WMWG-CAvexmoHXYRvGks5ruqj_gaJpZM4M5AUn>.
|
@bradleyrichter Bigger, on Linux alone? Or across all OSs? |
Test plan
Description
git rebase -i
to squash commits (if needed).Fixes #8185
Before:
After: