Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Standardizes on Lion badge design #8191

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Standardizes on Lion badge design #8191

merged 1 commit into from
Apr 10, 2017

Conversation

jonathansampson
Copy link
Collaborator

@jonathansampson jonathansampson commented Apr 10, 2017

Test plan

  1. Set LastPass as your active password manager in Preferences > Security
  2. Add a login/password for GitHub
  3. Go to https://github.com/login and the LastPass icon with badge should show in the top right corner
  4. Confirm it matches spec (below)

Description

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fixes #8185

Before:

image

After:

image

@jonathansampson jonathansampson added this to the 0.14.2 milestone Apr 10, 2017
Copy link
Contributor

@bradleyrichter bradleyrichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. We should monitor feedback on legibility of the minimized numbers but I think the tradeoff is worth it considering the alternative used by other browsers where the icon is mostly blocked by the badge.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 Similar to the Lion badge, the text is a little narrow / hard to read on Linux
screen shot 2017-04-10 at 10 27 12 am

@bsclifton bsclifton added design A design change, especially one which needs input from the design team. feature/extensions feature/titlebar QA/test-plan-specified release-notes/exclude labels Apr 10, 2017
@bsclifton bsclifton merged commit dadcc1c into master Apr 10, 2017
@bsclifton bsclifton deleted the unify-badge-styles branch April 10, 2017 17:36
@jonathansampson
Copy link
Collaborator Author

@bsclifton @bradleyrichter The font-game on Linux is weak. I spent some last last week looking at our options, and we have very few. We may need to package a font to use in that case. System-supported defaults were not very promising.

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Apr 10, 2017 via email

@jonathansampson
Copy link
Collaborator Author

@bradleyrichter Bigger, on Linux alone? Or across all OSs?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/extensions feature/titlebar QA/test-plan-specified release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants