This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Order the "recently closed" items in History menu in DESC order (top == last closed) #7672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…== last closed) Fixes #7548 Auditors: @jhreis, @NejcZdovc Test Plan: 1. Launch Brave and open 5 tabs, each to a unique page 2. Close 4 of the tabs, remembering the order you closed them in 3. Click the History menu 4. Under "Recently closed", the most recently closed tabs should be at the top
|
@NejcZdovc I created an issue for what we both saw happen: #7686 Merging 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Description
Fixes #7548
Auditors: @jhreis, @NejcZdovc
git rebase -ito squash commits (if needed).