This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Partial refactoring of about:about with Aphrodite #7671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #7670 - 'aboutAbout' is replaced with 'aboutBrave' because styles under '.sortableTable' is not used on about:about TODO: refactor less/about/history.less Auditors: @cezaraugusto @bsclifton Test Plan: 1. open about:about
|
@luixxiul can I go ahead and replace other styles here to Aphrodite and make it 100%? Getting rid of |
bsclifton
approved these changes
Apr 3, 2017
There was a problem hiding this comment.
LGTM 😄 per @cezaraugusto's feedback, we'll likely want to follow this up with a part two that fully converts it over to Aphrodite
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/needs-QA-attention ☕
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Description
Addresses #7670
TODO: refactor less/about/history.less
Auditors: @cezaraugusto @bsclifton
git rebase -ito squash commits (if needed).