This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Create <TextArea> and <DefaultTextArea> with Aphrodite #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cezaraugusto @bsclifton I am not quite whether I have correctly updated the test code. Would you please have a look at it? Thanks! |
There was a problem hiding this comment.
same comment as #7172 review regarding stringifying object keys for Aphrodite styles. Otherwise LGTM ++
@bsclifton maybe we can use this PR to also remove other cases in this file as well? They're not necessary and makes it harder IMO to differentiate between classes and pseudo-states (where they're necessary).
|
btw checked test changes and they failed but since it's failing on master as well I don't think it's related with this PR changes so ++ |
|
@cezaraugusto @bsclifton if you would please remove all quotes and add the fix to this PR :-) |
cezaraugusto
approved these changes
Feb 13, 2017
luixxiul
added
PR/work-in-progress ⚒
PR/ready-for-merge
feature/about-pages
and removed
PR/ready-for-merge
PR/work-in-progress ⚒
labels
luixxiul
changed the title
- Remove unneeded quotes from Aphrodite styles by @cezaraugusto Closes #7163 Auditors: Test Plan: 1. Open about:adblock 2. Input some strings inside the textarea 3. Make sure the font size is set to 14.5px 4. Make sure 10px margins exist on the top and the bottom of the textarea 5. Open about:styles 6. Make sure <TextForm> and <DefaultTextForm> are correctly displayed
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/ready-for-merge
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
<TextForm>and<DefaultTextForm>are correctly displayedDetails
Closes #7163
Auditors: @bsclifton @cezaraugusto
git rebase -ito squash commits (if needed).Test Plan: