This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Order tabs correctly when they have openers #6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still a couple of failing clone ones but they are legit problems. Auditors: @bsclifton
Auditors: @bridiver
bridiver
reviewed
Dec 21, 2016
| key: 1, | ||
| tabId: 2, | ||
| parentFrameKey: 3, | ||
| audioMuted: true, |
There was a problem hiding this comment.
I think this is the only one we need to handle and we can do that in electron - brave/muon#126
bridiver
reviewed
Dec 21, 2016
| partitionNumber: 4, | ||
| themeColor: 'ffffff', | ||
| computedThemeColor: 'aaaaaa', | ||
| history: ['http://brave.com'], |
There was a problem hiding this comment.
do we still need this now that we have history methods on the webview/webcontents? Are we still using it anywhere?
There was a problem hiding this comment.
Possibly we're using it in about: pages.
There was a problem hiding this comment.
can we replace that with tab/webview history now?
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.