Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Revert "Update: Add copy to clipboard for about brave page (fixes #5790)" #6184

Merged
merged 1 commit into from
Dec 13, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,3 @@ httpse.leveldb

# vim swap files
*.swp

# webstrom
.idea
15 changes: 1 addition & 14 deletions js/about/brave.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,12 @@ const React = require('react')
const Immutable = require('immutable')
const messages = require('../constants/messages')
const SortableTable = require('../components/sortableTable')
const aboutActions = require('./aboutActions')

const ipc = window.chrome.ipc

require('../../less/about/history.less')
require('../../node_modules/font-awesome/css/font-awesome.css')

const tranformVersionInfoToString = (versionInformation) =>
versionInformation
.reduce((coll, entry) => `${coll} \n${entry.get('name')}: ${entry.get('version')}`, '')

class AboutBrave extends React.Component {
constructor () {
super()
Expand All @@ -26,11 +21,6 @@ class AboutBrave extends React.Component {
this.setState({versionInformation: Immutable.fromJS(versionInformation)})
}
})
this.onCopy = this.onCopy.bind(this)
}

onCopy () {
aboutActions.setClipboard(tranformVersionInfoToString(this.state.versionInformation))
}

render () {
Expand All @@ -40,10 +30,7 @@ class AboutBrave extends React.Component {
</div>

<div className='siteDetailsPageContent aboutAbout'>
<div className='title'>
<span className='sectionTitle' data-l10n-id='versionInformation' />
<span className='fa fa-clipboard' title='Copy password to clipboard' onClick={this.onCopy} />
</div>
<div className='sectionTitle' data-l10n-id='versionInformation' />
<SortableTable
headings={['Name', 'Version']}
rows={this.state.versionInformation.map((entry) => [
Expand Down
8 changes: 1 addition & 7 deletions less/about/siteDetails.less
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,10 @@ body {
display: block;
clear: both;

.title {
width: 400px;
display: flex;
justify-content: space-between;
margin-left: @aboutPageSectionPadding;
}

.sectionTitle {
font-size: 16px;
margin-bottom: 12px;
padding-left: @aboutPageSectionPadding;
}
}
}
Expand Down