Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Remove 'chrome-extension://*' prefix from URL bar #2537

Merged
merged 1 commit into from
Jul 17, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Jul 17, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

fix #2534

@bbondy
Copy link
Member

bbondy commented Jul 17, 2016

Thanks for the patch, we should go with the more generalized startsWith then substring exact check though because there are some extension URLs we don't want to truncate. One example is if you enable dashlane it will open a sign in chrome extension page and make available a dashlane preferences page which is a chrome-extension URL.

@darkdh
Copy link
Member Author

darkdh commented Jul 17, 2016

You are right. We cannot always truncate all the chrome-extension URL.
888c5fa will be more flexible.

@diracdeltas
Copy link
Member

This should probably only happen if PDFJS is enabled in prefs. Otherwise LGTM!

@darkdh
Copy link
Member Author

darkdh commented Jul 17, 2016

Thanks @diracdeltas. Checking prefs is in bba8abf.

@diracdeltas
Copy link
Member

lgtm! please squash commits and i'll merge

@diracdeltas diracdeltas merged commit 1d15bfe into brave:master Jul 17, 2016
@luixxiul luixxiul added this to the 0.11.1dev milestone Jul 17, 2016
@darkdh darkdh deleted the 2534 branch July 18, 2016 12:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove prefix from URL bar of PDF files
4 participants