Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Add look up selection when there is a selection in macOS. Fixes #1627 #2315

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

jmalonzo
Copy link
Contributor

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

@bbondy
Copy link
Member

bbondy commented Jun 29, 2016

++ thanks! Eventually we need to make locale.translation take arguments as well so we can localize them properly but since we don't have that yet, what you did is fine.

@bbondy bbondy merged commit 5f6efd4 into brave:master Jun 29, 2016
@jmalonzo jmalonzo deleted the fix/1627 branch June 29, 2016 08:52
@luixxiul luixxiul added this to the 0.10.5dev milestone Jun 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants