Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Adjust bookmark hanger position to match bookmark button #14508

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Jun 21, 2018

Fix #14456

The position of the icon had changed relative to the container. Futhermore, the home button being shown / not shown no longer affects the positioning of the bookmark hanger since it is not within the same container anymore.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix #14456

The position of the icon had changed relative to the container. Futhermore, the home button being shown / not shown no longer affects the positioning of the bookmark hanger since it is not within the same container anymore.
@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 21, 2018
@petemill petemill self-assigned this Jun 21, 2018
@petemill petemill requested a review from bsclifton June 21, 2018 22:31
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested before/after; works great ++

@bsclifton bsclifton merged commit fedcf10 into master Jun 22, 2018
@bsclifton bsclifton deleted the fix/14456-bookmark-hanger-position branch June 22, 2018 00:05
bsclifton added a commit that referenced this pull request Jun 22, 2018
Adjust bookmark hanger position to match bookmark button
bsclifton added a commit that referenced this pull request Jun 22, 2018
Adjust bookmark hanger position to match bookmark button
@bsclifton
Copy link
Member

master fedcf10
0.24.x 389ab5e
0.23.x 4abefd5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants