Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Use ImmutableJS correctly for frameOpts #10382

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 10, 2017

This is already covered by misc-components automated tests, several were
failing that I didn't know were related.

Fix #10376

Auditors: @bsclifton

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

This is already covered by misc-components automated tests, several were
failing that I didn't know were related.

Fix #10376

Auditors: @bsclifton
@bbondy bbondy added this to the 0.18.x Hotfix milestone Aug 10, 2017
@bbondy bbondy self-assigned this Aug 10, 2017
@bbondy bbondy requested a review from bsclifton August 10, 2017 04:24
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@codecov-io
Copy link

codecov-io commented Aug 10, 2017

Codecov Report

Merging #10382 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #10382   +/-   ##
=======================================
  Coverage   53.74%   53.74%           
=======================================
  Files         238      238           
  Lines       21046    21046           
  Branches     3256     3256           
=======================================
  Hits        11312    11312           
  Misses       9734     9734
Flag Coverage Δ
#unittest 53.74% <0%> (ø) ⬆️
Impacted Files Coverage Δ
js/stores/appStore.js 11.63% <0%> (ø) ⬆️

@bsclifton bsclifton merged commit 23bffcd into master Aug 10, 2017
@bsclifton bsclifton deleted the open-new-link-in-window branch August 10, 2017 06:09
bsclifton added a commit that referenced this pull request Aug 10, 2017
Use ImmutableJS correctly for frameOpts
bsclifton added a commit that referenced this pull request Aug 10, 2017
Use ImmutableJS correctly for frameOpts
bsclifton added a commit that referenced this pull request Aug 10, 2017
Use ImmutableJS correctly for frameOpts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants