Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Support chrome://newtab/ as alias to about:newtab #7457

Closed
jonathansampson opened this issue Mar 2, 2017 · 2 comments
Closed

Support chrome://newtab/ as alias to about:newtab #7457

jonathansampson opened this issue Mar 2, 2017 · 2 comments
Labels
bug feature/extensions feature/newtab fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@jonathansampson
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Some extensions contain functionality to open a new tab. Vimium, for example, attempts to open up chrome://newtab, which is presently unsupported in Brave. The result is a tab pointed to about:error.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    0.13.4

  • Steps to reproduce:

    1. Install the Vimium extension
    2. Press t from a Vimium-enabled page
    3. Note error

  • Actual result:
    A new tab is opened, but the user is presented with an error.

  • Expected result:
    A new tab should be opened, pointing to the user's configured new-tab option.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes
@jonathansampson jonathansampson added this to the 0.13.6 milestone Mar 2, 2017
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
@bsclifton
Copy link
Member

bsclifton commented Mar 15, 2017 •
edited
Loading

Moving to 0.14.1

edit: UI support has been disabled for Vimium with 39e7bc6; when this issue is resolved, we can revert that commit (so it shows back up again)

@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 15, 2017
bsclifton added a commit that referenced this issue Mar 15, 2017
@bsclifton
Remove Vimium from the UI until it's ready to enable
39e7bc6 
- Vimium support was added with ce004b9
- this commit hides it from the UI; all underlying support is there
- we can revert this commit when other support (ex: #7457 and other issues) are solved

Auditors: @jonathansampson, @bbondy

Test Plan:
1. Launch Brave and open Preferences > Advanced Settings
2. Under "Enable Pocket" there should NOT be an "Enable Vimium" option
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@bsclifton
Copy link
Member

Moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 4, 2017
@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 4, 2017
@alexwykoff alexwykoff modified the milestones: Backlog, 0.15.1 Apr 18, 2017
@jonathansampson jonathansampson mentioned this issue Jul 13, 2017
Merged
8 tasks
@bsclifton bsclifton removed the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label Aug 30, 2017
@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 24, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/extensions feature/newtab fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathansampson @bbondy @alexwykoff @bsclifton