AltGr treated as Ctrl+Alt in Win32

[ralesk]

There's a very sad legacy in the Windows API which makes the AltGr key appear as if Left Ctrl and Right Alt had been pressed simultaneously. This sets Windows apart from every other OS in that handling the Third Level is utterly broken in it unless desktop and web site programmers pay attention to get around it.

The actual issue I noticed while running version 8ca0127 was that pressing AltGr+U (to type ú on the layout I use) brought up the View Source tab on the website I was interacting with.

This tells me two things:

• Brave does not pay attention to Windows's crippled legacy behaviour and mistakenly handles AltGr presses as Ctrl+Alt presses.
• Brave does not pay attention whether Alt is pressed or not, when expecting Ctrl+U for View Source (or, I suspect, any other Ctrl-based browser shortcut).

It is very likely that nobody wants to send Ctrl when they're trying to type a Level Three character, so I suspect the solution would be to catch any occurrence of fake Windows AltGr and swallow the fake Ctrl key press event that emanates from it. This is probably not as easy and straightforward as easy it is to say :)

[bsclifton]

@ralesk thanks for the report 😄 I believe I understand the issue...

With our framework, we can't directly capture Alt vs AltGr. However, we have the ability to check if it was the left or right (so two variables to check; key and location). I am positive this is the case for the issue you've discovered

Just for reference (in case you were interested in looking at the code), here is the pull request where I updated the menu to ignore AltGr. This shows the method which you can use for detecting it
#4628

[rickersilva]

This is back. I´mhaving the same issue today at my home PC, so typing things like the sharp or the at sign,in my spanish keyboard are annoying.

[bsclifton]

@rickersilva was it working in previous releases?

[rickersilva]

Yes. The problem is with the hash and at symbols, so I use them daily signing up on many sites and writing emails

…

On Wed, Feb 7, 2018, 17:17 Brian Clifton ***@***.***> wrote: @rickersilva <https://github.com/rickersilva> was it working in previous releases? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6915 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGAJIG_0U4O6qb4ojotUB2MQA8pLES7jks5tSiDpgaJpZM4Lw6p1> .

[bsclifton]

This appears to be fixed with our Developer channel release 😄 👍