Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Clicking inside url bar but not directly on url string does not focus #14473

Closed
petemill opened this issue Jun 20, 2018 · 1 comment
Closed

Clicking inside url bar but not directly on url string does not focus #14473

petemill opened this issue Jun 20, 2018 · 1 comment
Assignees
@petemill
Labels
0.23.x issue first seen in 0.23.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@petemill
Copy link
Member

petemill commented Jun 20, 2018 •
edited by bsclifton
Loading

Reported by @bradleyrichter

Description

Clicking anywhere in the url bar vertically should focus the text of the url bar (the url).

Test plan / Steps to Reproduce

  1. Visit a URL
  2. Unfocus the url bar by clicking in the content area
  3. Click the padding between the url bar border and the url text

Actual result:
Nothing happens

Expected result:
Url text is selected

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.23.11
V8: 6.7.288.46
rev: 6565c06
Muon: 7.1.0
OS Release: 17.5.0
Update Channel: Beta
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 67.0.3396.87

Reproducible on current live release:
No
@petemill petemill added regression 0.23.x issue first seen in 0.23.x labels Jun 20, 2018
@petemill petemill added this to the 0.23.x (Beta Channel) milestone Jun 20, 2018
@petemill petemill self-assigned this Jun 20, 2018
petemill added a commit that referenced this issue Jun 22, 2018
@petemill
Make the entire height of the url bar a hit target for focus
fb0fcfe 
Fix #14473
@petemill petemill mentioned this issue Jun 22, 2018
Merged
10 tasks
This was referenced Jun 25, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 25, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.23.x issue first seen in 0.23.x QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @kjozwiak @bsclifton @srirambv @LaurenWags @btlechowski