Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

Save file/Export file renames to Downloads instead of actual file name #14407

Closed
GeetaSarvadnya opened this issue Jun 14, 2018 · 4 comments · Fixed by brave/muon#615
Closed

Save file/Export file renames to Downloads instead of actual file name #14407

GeetaSarvadnya opened this issue Jun 14, 2018 · 4 comments · Fixed by brave/muon#615
Assignees
@bsclifton
Labels
0.23.x issue first seen in 0.23.x feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 14, 2018 •
edited
Loading

Description

Click on Save recovery file is downloading a file which has 'Downloads' name instead of brave_wallet_recovery

Steps to Reproduce

  1. Open the Brave with clean profile
  2. Add few sites to Ledger
  3. Click on Advanced setting->Backup your wallet->Save recovery file

Actual result:
Click on Save recovery file is downloading a file which has 'Downloads' name instead of brave_wallet_recovery
ledger-save recovery file

Expected result:
Downloaded file name should be "brave_wallet_recovery.txt"

Reproduces how often:
Easy

Brave Version

0.23.8
about:brave info:

Brave: 0.23.8
V8: 6.6.346.32
rev: 06c657b
Muon: 6.1.5
OS Release: 10.0.17134
Update Channel: Beta
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 66.0.3359.181

Reproducible on current live release:
No

Additional Information
@GeetaSarvadnya GeetaSarvadnya added this to the 0.23.x (Beta Channel) milestone Jun 14, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Click on Save recovery file is downloading a file which has 'Download' name instead of brave_wallet_recovery Click on Save recovery file is downloading a file which has 'Downloads' name instead of brave_wallet_recovery Jun 14, 2018
@srirambv
Copy link
Collaborator

This is not limited to download file. Exporting bookmark also shows as Downloads.html

@ryanml ryanml self-assigned this Jun 14, 2018
@srirambv srirambv changed the title Click on Save recovery file is downloading a file which has 'Downloads' name instead of brave_wallet_recovery Save file/Export file renames to Downloads instead of actual file name Jun 14, 2018
@srirambv
Copy link
Collaborator

On Linux it doesn't show any file name either while saving backup keys or while exporting bookmarks file
14407

@alexwykoff alexwykoff added priority/P3 Major loss of function. release/blocking labels Jun 19, 2018
@bsclifton
Copy link
Member

Removing OS specific labels as weird behavior happens on macOS also:
screen shot 2018-06-19 at 4 52 34 pm

@LaurenWags LaurenWags mentioned this issue Jun 20, 2018
Closed
darkdh added a commit to brave/muon that referenced this issue Jun 20, 2018
@darkdh
Remove DIR_DEFAULT_DOWNLOADS_SAFE which is covered by DownloadPrefs
af569c6 
miscommunication in
#508 (review)

fix brave/browser-laptop#14407

Auditors: @bridiver, @jumde
@darkdh darkdh mentioned this issue Jun 20, 2018
Merged
This was referenced Jun 25, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jun 25, 2018 •
edited by btlechowski
Loading

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 25, 2018
Closed
@kjozwiak kjozwiak added release-notes/exclude 0.23.x issue first seen in 0.23.x labels Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
0.23.x issue first seen in 0.23.x feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Remove DIR_DEFAULT_DOWNLOADS_SAFE which is covered by DownloadPrefs brave/muon
8 participants
@alexwykoff @kjozwiak @bsclifton @ryanml @srirambv @LaurenWags @btlechowski @GeetaSarvadnya