This repository was archived by the owner on Dec 11, 2019. It is now read-only.
add tab-preview timer reset when entering and exiting tab bar to remove unwanted previewing #1434
Assignees
Milestone
Comments
|
Increasing the default timer would be a good idea. Mouseover happens frequently regardless of going to the address bar, and it creates a confusing experience as the previews 'flash' in and out very quickly. |
bbondy
added a commit
that referenced
this issue
Jul 27, 2016
Add tab-preview timer for non-previewmode. Closes #1434
2 tasks
lucidNTR
pushed a commit
to lucidNTR/browser-laptop
that referenced
this issue
Sep 30, 2016
- fixes brave#3271: Dont show tab preview unless mouse velocity is low enough - tab preview requires that either: mouse be moving slower than a velocity threshold relative to tab size (so should be relative to resolution) mouse hover for longer than a new mouseover duration threshold (this may be unnecessary, velocity seems fine) - 50% higher mouse velocity is tolerated if user is in "preview mode" (moving mouse from one tab to another, see issue brave#1434) to avoid flashing out when mousing from one tab preview to another - velocity threshold is set in `constants/settings.js`: `tabs.tab-previews.mouse-velocity-threshold` - mouseover duration threshold is set in `constants/settings.js`: `tabs.tab-previews.mouseover-duration-threshold-ms`
lucidNTR
pushed a commit
to lucidNTR/browser-laptop
that referenced
this issue
Sep 30, 2016
- fixes brave#3271: Dont show tab preview unless mouse velocity is low enough - tab preview requires that either: mouse be moving slower than a velocity threshold relative to tab size (so should be relative to resolution) mouse hover for longer than a new mouseover duration threshold (this may be unnecessary, velocity seems fine) - 50% higher mouse velocity is tolerated if user is in "preview mode" (moving mouse from one tab to another, see issue brave#1434) to avoid flashing out when mousing from one tab preview to another - velocity threshold is set in `constants/settings.js`: `tabs.tab-previews.mouse-velocity-threshold` - mouseover duration threshold is set in `constants/settings.js`: `tabs.tab-previews.mouseover-duration-threshold-ms`
lucidNTR
pushed a commit
to lucidNTR/browser-laptop
that referenced
this issue
Oct 1, 2016
- fixes brave#3271: Dont show tab preview unless mouse velocity is low enough - tab preview requires that either: mouse be moving slower than a velocity threshold relative to tab size (so should be relative to resolution) mouse hover for longer than a new mouseover duration threshold (this may be unnecessary, velocity seems fine) - 50% higher mouse velocity is tolerated if user is in "preview mode" (moving mouse from one tab to another, see issue brave#1434) to avoid flashing out when mousing from one tab preview to another - velocity threshold is set in `constants/settings.js`: `tabs.tab-previews.mouse-velocity-threshold` - mouseover duration threshold is set in `constants/settings.js`: `tabs.tab-previews.mouseover-duration-threshold-ms`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
User returns to the URL bar constantly. This mouse travel invokes the tab preview timer because the mouse moves over the tabs on the way to the URL bar. Because the tab bar is re-entered before the timer ends, the preview is shown on the way back to the page.
The text was updated successfully, but these errors were encountered: