-
Notifications
You must be signed in to change notification settings - Fork 970
Use better name mappings for channels on about:brave #10239
Comments
hello @bsclifton! I am interested to work on this bug, if it is not taken yet, can I fix it ? |
@prasanthp96 Go ahead. I am a little busy these days so I cannot take on this issue. |
@prasanthp96 that would be great! 😄 Please do work on it (I'll reserve it for you by assigning myself). Let me know if you have any questions 😄 |
@prasanthp96 have you had a chance to check this one out yet? Let me know how it's going 😄 |
Hy @bsclifton , sorry for the delay, I will start working on this today. |
@bsclifton I could see only three channels listed in https://github.com/brave/browser-laptop/blob/master/app/channel.js. Will it suffice changing these alone ? or should I alter any other code? |
@prasanthp96 I'd say let's move forward with just Once you have the mapping in place, it should be easy to adjust once we have the new channels ( |
@bsclifton I have sent an PR, have a look! |
Test plan
Release
Beta
Original issue description
We should map the following identifiers in about:brave to the real channel name:
This will avoid people using the confusing internal names to refer to the channels.
dev -> Release
beta -> Beta
developer -> Developer
nightly -> Nightly
The text was updated successfully, but these errors were encountered: