Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

favicon from closed tab comes up on new website tab? #10176

Closed
patrick99e99 opened this issue Jul 27, 2017 · 8 comments
Closed

favicon from closed tab comes up on new website tab? #10176

patrick99e99 opened this issue Jul 27, 2017 · 8 comments

Comments

@patrick99e99
Copy link

  • Did you search for similar issues before submitting this one?
    YES

  • Describe the issue you encountered:

I was visiting a webpage:
https://investorshub.advfn.com/boards/read_msg.aspx?message_id=133353270

I had my my mouse on the "next" link on the right side of the page (under the search bar), and was trying to click it to move to the next message in the thread. After the webpage finished loading, the content jumps--- so when I clicked "next", the content had shifted up causing me to click on "E*Trade" instead of the Next link.

A new window popped opened up with etrade.. Once I saw I was on E*Trade, I closed the window, as it was not my intention to go there...

A few minutes later, I clicked a different link from a slack channel, and I noticed that the Favicon for that website had somehow become E*Trade's favicon!!!

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Mac OS X 10.10.5 (14F2411)

  • Brave Version (revision SHA):
    0.17.19

  • Steps to reproduce:
    cannot seem to reproduce

  • Actual result:
    Wrong favicon!

  • Expected result:
    Correct favicon!

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    N/A

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Unfortunately I can't seem to make it happen again...

  • Extra QA steps:
    N/A

  • Screenshot if needed:

screen shot 2017-07-27 at 11 21 38 am

  • Any related issues:
    Note that in the screenshot, I am showing that I have two tabs of the same webpage open, the one on the right "[Integration] Runner - Asset" with the two orange/red chevrons has the correct favicon.. The one to the left has E*Trade's favicon.
@bsclifton
Copy link
Member

bsclifton commented Jul 28, 2017

Thanks for the report, @patrick99e99 😄 This issue is a duplicate of #1646

Since you have better steps, I'll update the original issue and give it a +1 on your behalf 😄

@bsclifton bsclifton marked this as a duplicate of #1646 Jul 28, 2017
@bsclifton bsclifton added the duplicate Issue has already been reported label Jul 28, 2017
@bsclifton
Copy link
Member

bsclifton commented Jul 28, 2017

After re-reading, I was mistaken: this appears to be different (but related). Re-opening 😄

@bsclifton bsclifton reopened this Jul 28, 2017
@bsclifton bsclifton added feature/tabsbar and removed duplicate Issue has already been reported labels Jul 28, 2017
@LaurenWags
Copy link
Member

Just saw this on 0.18.24. I had 2 pinned tabs (one of which was github.com) and about 25 tabs open. I clicked on the non-pinned tab next to my pinned tabs and started closing the tabs in quick succession (using the x icon on the tab, not cmd+w or right click to close tab). After closing about 12-13 tabs I noticed that my pinned tab was now displaying the wrong favicon:
screen shot 2017-08-31 at 2 39 31 pm

@LaurenWags
Copy link
Member

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@LaurenWags
Copy link
Member

@LaurenWags
Copy link
Member

Reproduced on 0.22.716 - had multiple tab pages open, Opened Preferences, enabled Metamask, after the metamask page opened, I closed it and Preferences got the MetaMask favicon:
screen shot 2018-05-18 at 9 18 41 am

@srirambv
Copy link
Collaborator

This looks similar to #6513 which has been an issue for a while.

@LaurenWags
Copy link
Member

yep - I definitely think #10176 (comment) is a case of #6513. thanks!

@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants