fix: react-router was breaking #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overzealous upgrading of overrides by renovate means that path-to-regexp got upragded from 1.9 to 8.2, which breaks react-router@5. On staging, ads-ui simply doesn't load as a result. Switch the overrides section back to how it used to be, explicilty describing the vulnerable versions to avoid, rather than randomly picking the latest version.
tmancey
approved these changes
Feb 26, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overzealous upgrading of overrides by renovate means that path-to-regexp got upgraded from 1.9 to 8.2, which breaks react-router@5. On staging, ads-ui simply doesn't load as a result.
Switch the overrides section back to how it used to be, explicitly describing the vulnerable versions to avoid, rather than randomly picking the latest version. Then renovate can actually pick the correct version to use.