Feature/replace key #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exist out of primary 'resources' object, stub out some logic to offer to move translation based on its original location
…plumb through 'placeHolder' param for selection wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2 Ability to replace copy for a specific key
Resolves #8 Add flexibility for object/initializer that is used for adding/updating copy in culture file
Fits the primary use-case, though longer copy is still tedious to update (input box does not seem to scale to prefilled value, so it is one long string..). May benefit from a follow up feature that adds a setting to bring up the copy in an editor window with word-wrap auto-enabled if it exceeds some specific length, but this should be a good start.
For #8, I added support for reading from the first object literal in the culture file that contains the specified property. After doing some testing with our actual client files that are broken up in the way described in that issue, it was failing to find most of the keys that had already been professionally translated. If attempting to update a key that is not placed in the inline 'resources' object, it will prompt the user if they want to move the property to it for housekeeping purposes. (marking it as 'placeholder' translated)