Custom column type update - BRA-1935 #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into tara/bra-1935
… into tara/bra-1935
… into tara/bra-1935
manugoyal
reviewed
Feb 12, 2025
core/js/typespecs/app_types.ts
Outdated
| @@ -177,12 +177,18 @@ const customColumnBaseSchema = generateBaseTableSchema("custom columns"); | |||
| export const customColumnSchema = z | |||
| .object({ | |||
| id: customColumnBaseSchema.shape.id, | |||
| object_type: aclObjectTypeEnum, | |||
| object_type: z | |||
There was a problem hiding this comment.
I wonder if we should actually leave these as-is, and just use a less-permissive version of the schema on the API side. The benefit being that control-plane-side (which is always in sync with the latest typespecs) we still get the stricter typing benefits, but data-plane-side we decay these to strings. Not a terribly strong opinion here, so either way works.
… into tara/bra-1935
… into tara/bra-1935
… into tara/bra-1935
… into tara/bra-1935
… into tara/bra-1935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update custom column type