fix pyright for logger.py #546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugoyal
reviewed
Jan 29, 2025
| @@ -2392,7 +2402,9 @@ def compute_parent_object_id(): | |||
| return parent_object_id.get() | |||
|
|
|||
| arg_parent_object_id = LazyValue(compute_parent_object_id, use_mutex=False) | |||
| if parent_components.row_id: | |||
| if parent_components.row_id is not None: | |||
There was a problem hiding this comment.
Hmm kind-of annoying. Maybe we should change the span_identifier_v3.py representation to store these three fields in their own TypedDict, which is Optional, so that the type system can make this inference naturally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.