EPS-1121: Accessibility check in UAE Lite #1121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushmak02
reviewed
Feb 27, 2025
| @@ -777,7 +777,7 @@ protected function render():void { | |||
| $home_class = ( 'yes' === $settings['show_home'] ) ? 'hfe-breadcrumbs-show-home' : ''; | |||
|
|
|||
| // Build the breadcrumb output. | |||
| $output = '<ul class="hfe-breadcrumbs ' . esc_attr( $home_class ) . '">'; | |||
| $output = '<nav aria-label="Breadcrumb"><ul class="hfe-breadcrumbs ' . esc_attr( $home_class ) . '">'; | |||
There was a problem hiding this comment.
nav is added as a wrapper to ul tag. Make sure we test this change with different themes. Mostly themes add CSS for nav elements.
@Bhikule19
There was a problem hiding this comment.
Sure, will test this with multiple themes
|
https://prnt.sc/S43QRlqnrDAs - Even if there is alt text added, on voice over it is voicing, can you please check. |
|
https://prnt.sc/eIenZLvBaNks - Check using Lighthouse tool and retest the accessibility once. @Bhikule19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[BSF-PR-SUMMARY]
Screenshots
Types of changes
How has this been tested?
Checklist: