EPS-1056: Removed deprecated class .elementor-button-wrapper #1062
Conversation
| @@ -403,8 +403,8 @@ protected function register_general_content_controls() { | |||
| ], | |||
| 'selectors' => [ | |||
| '{{WRAPPER}} li.menu-item a' => 'justify-content: {{VALUE}};', | |||
| '{{WRAPPER}} li .elementor-button-wrapper' => 'text-align: {{VALUE}};', | |||
| '{{WRAPPER}}.hfe-menu-item-flex-end li .elementor-button-wrapper' => 'text-align: right;', | |||
| '{{WRAPPER}} li.hfe-button-wrapper' => 'text-align: {{VALUE}};', | |||
There was a problem hiding this comment.
there is a space after li
li .elementor-button-wrapper
confirm if we are replacing .hfe-button-wrapper exactly with .elementor-button-wrapper then space should be addedhere too
There was a problem hiding this comment.
Yes, we are replacing it, checked here - https://prnt.sc/-_kSOsgmCQ8-
It doesn't affect either way, I will add space wrt older ref
readme.txt
Outdated
| @@ -135,6 +135,7 @@ To access the advanced features and premium widgets, you’ll need to upgrade to | |||
| - Fix: "Function map_meta_cap called incorrectly" notice appearing for logged out users when shortcode executed manually. | |||
| - Fix: Deprecated constant FILTER_SANITIZE_STRING replaced to ensure compatibility with PHP. | |||
| - Fix: Resolved PHP error with NPS library. | |||
| - Improvement: Removed 'elementor-button-wrapper' to enhance performance and optimize the DOM structure. | |||
There was a problem hiding this comment.
Improvement should be added at the top
There was a problem hiding this comment.
Updated in new dev version
| @@ -625,7 +625,7 @@ protected function render() { | |||
| <?php | |||
| } else { | |||
| ?> | |||
| <div class="hfe-menu-cart__toggle elementor-button-wrapper"> | |||
| <div class="hfe-menu-cart__toggle"> | |||
| <a id="hfe-menu-cart__toggle_button" href="<?php echo esc_url( wc_get_cart_url() ); ?>" class="elementor-button hfe-cart-container" aria-label="<?php esc_attr_e( 'Cart', 'header-footer-elementor' ); ?>"> | |||
There was a problem hiding this comment.
Add "hfe-button-wrapper" class here, it is not showing the cart button when we click on it and go to the cart page.
There was a problem hiding this comment.
Updated - https://prnt.sc/zkX2pNg9_vTS
Description
[BSF-PR-SUMMARY]
Removed deprecated class .elementor-button-wrapper
Widget
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Checklist: