minor bug fix utils.retrieve_over_http #521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
While adding a test for
utils.retrieve_over_http
(see add test_atlas_repr_from_name) I noticed that when there is a connection error and no file in the specifiedoutput_file_path
exists, the block of code below errors atoutput_file_path.unlink()
, throwing anFileNotFoundError
, instead of raising theConnectionError
(which is I think what is desired in this case).What does this PR do?
sets
output_file_path.unlink(missing_ok=True)
so that the correct error message is shown in case of anConnectionError
.References
#518
How has this PR been tested?
Added
test_retrieve_over_http_ConnectionError
totest_utils.py
withXFAIL
marker that can be removed after this PR is merged.Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: