Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom coverage action with py-cov-comment #113

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

LGro
Copy link
Member

@LGro LGro commented Jun 5, 2023

Our self made coverage reporting wasn't only causing failing tests to slip (#111) but also hid the errors when they occurred. So here is an attempt to switch to https://github.com/marketplace/actions/python-coverage-comment as recommended by @dynobo.

@LGro LGro force-pushed the feature/python-coverage-comment-action branch 5 times, most recently from 2f6e9e5 to 7690eb7 Compare June 5, 2023 14:43
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Coverage report

Note
No coverage data of the default branch was found for comparison. A possible reason for this is that the coverage action has not yet run after a push event and the data is therefore not yet initialized.

The coverage rate is 89.52%.
The branch rate is 87%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Signed-off-by: Grossberger Lukas (CR/AIR2.2) <Lukas.Grossberger@de.bosch.com>
@LGro LGro force-pushed the feature/python-coverage-comment-action branch from 7690eb7 to 249db77 Compare June 5, 2023 14:50
@LGro LGro requested review from dynobo and lreeb June 5, 2023 14:53
Copy link
Collaborator

@dynobo dynobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LGro LGro merged commit 05ebbbb into main Jun 6, 2023
@LGro LGro deleted the feature/python-coverage-comment-action branch June 6, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants