Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre eval callback and stringify user info for logging #109

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

LGro
Copy link
Member

@LGro LGro commented Jun 5, 2023

@LGro LGro requested review from sfalkner and aeivazi June 5, 2023 13:33
@github-actions

This comment was marked as outdated.

@LGro LGro force-pushed the feature/sequental-loop-callbacks branch from 8a6c97c to b7d0945 Compare June 5, 2023 14:07
Signed-off-by: Grossberger Lukas (CR/AIR2.2) <Lukas.Grossberger@de.bosch.com>
@LGro LGro force-pushed the feature/sequental-loop-callbacks branch from b7d0945 to 6df4cca Compare June 6, 2023 07:38
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage report

Note
No coverage data of the default branch was found for comparison. A possible reason for this is that the coverage action has not yet run after a push event and the data is therefore not yet initialized.

The coverage rate is 89.54%.
The branch rate is 87%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

blackboxopt/optimization_loops/sequential.py

100% of new lines are covered (89.58% of the complete file).

Copy link
Collaborator

@dynobo dynobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I'm only curious, for which use-cases this feature is used. :-)

Copy link
Collaborator

@sfalkner sfalkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LGro. These changes make the optimization loop more flexible 👍

LGro added 2 commits June 6, 2023 13:58
Signed-off-by: Grossberger Lukas (CR/AIR2.2) <Lukas.Grossberger@de.bosch.com>
Signed-off-by: Grossberger Lukas (CR/AIR2.2) <Lukas.Grossberger@de.bosch.com>
@LGro LGro merged commit c7a78c1 into main Jun 9, 2023
@LGro LGro deleted the feature/sequental-loop-callbacks branch June 9, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON dump in optimization loop logging fails for some user_info values
4 participants