Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve transparency #14

Merged
merged 1 commit into from
Aug 31, 2016
Merged

Preserve transparency #14

merged 1 commit into from
Aug 31, 2016

Conversation

aesopwolf
Copy link
Contributor

By removing the call to flatten() then we're able to preserve the alpha channel automatically without introducing the background attribute

@izaakschroeder
Copy link
Collaborator

I think flatten() was originally there due to an issue with older versions of sharp (my original issue here: lovell/sharp#301). I feel it's probably ok to remove this now, though you need to fix up the code errors you have. 😄

@izaakschroeder izaakschroeder self-assigned this Aug 26, 2016
@aesopwolf
Copy link
Contributor Author

Dang, that's what I get for trying to edit source code in the GitHub UI.

@coveralls
Copy link

coveralls commented Aug 26, 2016

Coverage Status

Changes Unknown when pulling cdd0660 on aesopwolf:patch-1 into * on metalabdesign:master*.

@izaakschroeder
Copy link
Collaborator

Lovely! Sorry for the delay here, last thing before merging is if we could get these commits all squashed down and tidy up the commit message?

e.g.

Remove unnecessary call to `flatten`.

This allows the user to preserve transparency. The call was originally in place to deal with an older SVG bug.

Then we'll be all set! 😄

This allows the user to preserve transparency. The call was originally in place to deal with an older SVG bug.
@coveralls
Copy link

coveralls commented Aug 31, 2016

Coverage Status

Changes Unknown when pulling 90b2c85 on aesopwolf:patch-1 into * on metalabdesign:master*.

@izaakschroeder izaakschroeder merged commit 323a88d into bootstarted:master Aug 31, 2016
@aesopwolf aesopwolf deleted the patch-1 branch August 31, 2016 03:01
@izaakschroeder
Copy link
Collaborator

Shipping as part of #15 😄

@izaakschroeder
Copy link
Collaborator

Published as part of + sharp-loader@0.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants